search

MattHodge / Graphite-PowerShell-Functions

A group of PowerShell functions that allow you to send Windows Performance counters to a Graphite Server, all configurable from a simple XML file.
https://hodgkins.io/using-powershell-to-send-metrics-graphite
GNU General Public License v3.0
218 stars 71 forks source link

Fixing some things... #25

Open ghostsquad opened 9 years ago

ghostsquad commented 9 years ago

Sorry, I should have wrote tests first! I'll work on that next so that future commits can be validated. I was thinking Pester for a test framework. Or writing this in C# and testing using Xunit.

MattHodge commented 9 years ago

Hi @ghostsquad .. I actually started just looking at Pester for this exact reason.

I'd love for you to make the first commit for the Pester tests so I can see the direction I should be going in with them :)

MattHodge commented 9 years ago

@ghostsquad are you ok with making a feature request and closing this pull request?

ghostsquad commented 9 years ago

@MattHodge, ya I'll make a feature request. Please merge what you feel is appropriate from this pull request. Some of the throws make sense, as you suggested though, not all of them.