Closed dvdvideo1234 closed 2 years ago
Please merge after my friend tests it in his server
Looks pretty reasonable to me, what security is being improved here exactly?
My friend is a server owner and he is concerned string.find
does not use safe patterns ( containing special characters ), so I optimized UID validation. The library method jcon.isValidUID
now uses:
Only the tool will call the validation with second argument so the users can only enter pattern safe characters in the textbox.
Okay, sounds good to me! Let me know when your friend has finished testing it, I'll take your word for it
Also liking the conversion from tabs -> spaces, nice!
Made my personal primary test:
@MattJeanes
Ok with me whenever you are ready ;)
Easier for you to review and merge: https://github.com/MattJeanes/Joystick-Module/pull/49/files?diff=unified&w=1