search

MattJeanes / PewPew

Divran's old GCombat remake now up to date for Garry's Mod 13.
7 stars 9 forks source link

Fixes PewPew core #41

Closed X-Coder closed 7 years ago

X-Coder commented 7 years ago

Timers were broken, changed to garrysmod 13 style timers

X-Coder commented 7 years ago

This fixes PewPew core and explosion effects on damaged props.

I tested it with "Toggle Core Damage Only" enabled: without this fix, it will only remove the core, but not the attached damaged props.

The RemoveAllProps was not working because of broken pre garrysmod 13 style timers. With garrysmod 13, function arguments for timers are not possible any more because garry removed it.

Also 'not type(props)=="table"' isn't working for me, it returns false, no matter what type it is, it worked after changing it to '!='.

With 100+ props attached it currently badly lags my server until the second timer kicks in, which removes all the props, maybe this can be improved somehow in the future, for example by removing the props faster when there are many props. Currently it takes up to a minute or more, leaving the server unresponsive and lagging.

MattJeanes commented 7 years ago

Oh right I didn't know they removed function args in timers. Well it's just fixing existing functionality so I'll merge this and deploy to Workshop, code looks good 👍

Cheers

MattJeanes commented 7 years ago

http://steamcommunity.com/sharedfiles/filedetails/changelog/138007714