MattJeanes / TARDIS

Time and Relative Dimension in Space, for Garry's Mod
MIT License
63 stars 27 forks source link

Interior entities have no owner #890

Open NovaAstral opened 1 year ago

NovaAstral commented 1 year ago

I've noticed recently that interior entities actually have no owner (probably the reason fpp has so many problems with it!)

If you use e2 to look into it, running entity():isWeldedTo():owner() on anything in the interior returns null

MattJeanes commented 1 year ago

I cannot replicate this issue at least in singleplayer, the exterior, interior and all parts are owned by the player who spawned it and I've checked the code in Doors and the TARDIS and everything looks good to me. It even uses CPPI which FPP implements here: https://github.com/FPtje/Falcos-Prop-protection/blob/master/lua/fpp/sh_cppi.lua

I'm testing using Evolve admin mod but I see no reason why it should behave differently on any other admin mod implementing CPPI.

Wiremod itself uses CPPI when available to determine who owns an entity: https://github.com/wiremod/wire/blob/master/lua/entities/gmod_wire_expression2/core/e2lib.lua#L176

I've tested the E2 code above spawned on the interior and a part and it's all working

image

More info on CPPI: http://ulyssesmod.net/archive/CPPI_v1-1.pdf