search

MattKetmo / EmailChecker

Disposable email detection library for PHP
MIT License
265 stars 79 forks source link

always return true #32

Open Grald opened 8 years ago

Grald commented 8 years ago

i am using laravel 5.2 always return true even if wrong email address provided

MattKetmo commented 8 years ago

/ping @olsgreen ;)

olsgreen commented 8 years ago

@Grald Are you using the validator or trying to use it via DI or a facade?

josephsong commented 7 years ago

I'm seeing this, too, in Laravel. I've tried using it via DI and by plain instantiation (new EmailChecker).

olsgreen commented 7 years ago

@josephsong Which version of Laravel are you using?

josephsong commented 7 years ago

Actually, Lumen v5.3.3.

josephsong commented 7 years ago

Well, it is funny. If I use yopmail.com as the domain for the test email, it does return false on the isValid call. But for any others I've tried from the list in this package, it still returns true.

josephsong commented 7 years ago

It seems that any of the domains in tests/EmailChecker/Tests/Adpater/BuiltInAdapterTest.php do come back as false. But any others in res/throwaway_domains.txt come back as true.

I had just successfully implemented this package in WordPress, and all domains in the throwaway_domain.txt are marked as invalid. Seems to be something specific to Laravel/Lumen.