search

MattKetmo / EmailChecker

Disposable email detection library for PHP
MIT License
265 stars 79 forks source link

added php 7.3 to travis tests #59

Closed rvitaliy closed 5 years ago

rvitaliy commented 5 years ago

@MattKetmo build fails because knplabs/gaufrette dependency not support php 7.3 before current release: https://github.com/KnpLabs/Gaufrette/releases/tag/v0.8.0 so to update this lib to full support php 7.3 we must upgrade php min requirements to 7.1 and upgrade all dev dependency to new releases. It's can be a new major release, what do you think about this?

MattKetmo commented 5 years ago

Hello. Bumping Gaufrette should be done easily since there is no change in the method signature the lib uses. So no need for major bump of EmailChecker. I just did the change in composer.json. Let's see if PHP 7.3 can now be added ;)