search

MattKetmo / darkroomjs

Extensible image editing tool in your browser
https://mattketmo.github.io/darkroomjs
MIT License
1.42k stars 405 forks source link

Add navigation events to history plugin. #38

Closed natecox closed 9 years ago

natecox commented 9 years ago

This is a small update that adds an event to the goForward and goBack methods of the history plugin, so that listening applications can act appropriately on viewed image change if needed.

Note: I initially thought to use use image:change instead of creating a new event, but it caused cyclical calls to the internal method of popping content onto the history stack.

natecox commented 9 years ago

I've also removed /build from the ignore lists for git and bower. In order for this library to be viable for distribution on Bower you should have immediate access to the CSS and JS needed to run the project, rather than have to build it yourself.

MattKetmo commented 9 years ago

Hello. Sorry for the delay, I've merged your PR with 55b4ab9 + b65ff65. Thank you.

MattKetmo commented 9 years ago

Btw, is there a reason to downgrade the version in the bower.json?

natecox commented 9 years ago

I actually published my fork to bower temporarily so that I could use the changes I made and lowered the version to make a clear distinction. Should definitely be bumped back up.