search

MattKetmo / darkroomjs

Extensible image editing tool in your browser
https://mattketmo.github.io/darkroomjs
MIT License
1.41k stars 406 forks source link

very needed features for web publishing #39

Closed ahimta closed 8 years ago

ahimta commented 9 years ago

The code for very needed features for web publishing #32

MattKetmo commented 8 years ago

Thanks @Ahimta for all the work you've done here. However I won't merge it anyway. There are features I don't want here and the code diverge too much (plus next major release will change a lot). I encourage you to keep your fork if you still need all of this.

ahimta commented 8 years ago

Thanks @MattKetmo for taking the time to review this.

I worked on this ages ago, since then I've worked and studied more software development, math and even geometry.

Now that I have more experience, especially in Javascript and DOM API, I can see that this PR needs much work in addition to porting it to the upstream Darkroomjs.

Anyways, I don't have much time these days, so I will leave things as is for now and those who really want these features can either port them themselves or post a bounty on Bountysource to make it worth my time.