search

MattLightfoot / USEC_General

USEC Public Issue Tracker and Wiki
http://www.usecforce.com/
4 stars 0 forks source link

Maunder's callsign is misaligned on the roster #22

Closed assaultboy closed 9 years ago

assaultboy commented 9 years ago

It seems like his name and callsign are using two different alignment modes because they are offset from each other.

It might be due to his massive image of a rank icon.

image

jonpas commented 9 years ago

Looking all good on my side. Can you do CTRL+F5 (clear cache) and see if that fixes it? Also what browser are you using? I guess this is UCOM roster page?

codethirteen commented 9 years ago

It's an image alignment issue that I fixed on my local dev environment. Problem is we can't target that specific image (and staff sergeant and above does it too) without a script to recognize it. The fix is vertical-align: middle on the image and increasing line-height to be more than the tallest image. That will center everything out.

SyMP2005 commented 9 years ago

Same for Joel Restrepo's!

jonpas commented 9 years ago

Assigning to you @codethirteen since you know what the problem is.

codethirteen commented 9 years ago

Work browser(s) - could see issue. Home browser(s) - Nada, all looks good.

I can't see a fix in our Github commit history, so that's strange. Someone reply here if they still see this issue please.

jonpas commented 9 years ago

Uhm, no one commited a fix so. :P

codethirteen commented 9 years ago

lol, check style.css file for last modification time... looks like someone added line-height directly, cos it doesn't show in release branch. :P

jonpas commented 9 years ago

Nope, whenever something gets committed to GitHub it will drop all local changes in favor of GitHub build, on both release and master.

codethirteen commented 9 years ago

OK I need coffee, I coulda sworn I didn't see the line-height for main class ten minutes ago, now I do and it's always been there... ok well this issue can be closed until someone brings it up again.

jonpas commented 9 years ago

So what now? I am confused, does it work or is it random or?

codethirteen commented 9 years ago

No I am not sure if this was ever a real issue. I used my browserstack.com account this morning to check it on a lot of different browsers, and could not see the problem.

So you were most likely correct in your initial reply: It was probably a caching issue, but clearing cache did not fix it for me at the time. At work I'm behind government firewalls and proxies, so that could have caused it for me.

If it reappears we can reopen this issue.

codethirteen commented 9 years ago

I am seeing this on the unit rosters, not the main roster. So I'm moving this over to the website's issues and keeping this one closed.