Squad Leader tag below name on unit roster

[assaultboy]

The squad leader tag on the unit roster page is below the holders name.

This conflicts with the alignment of every other tag which is to the right of the holders name. I'm assuming this is not intended, but if it is I recommend changing it to fit with the styling of the other tags.

[jonpas]

Can you supply a screenshot of how it conflicts with the alignment?

[assaultboy]

Not home right now, I'll take one when I get home.

It's also not "broken" it's just different from every other tag

[jonpas]

Yep I know, hence why I labeled it with enhancement. ;)

[assaultboy]

Here are some examples. Notcie how the tag is below Vuk's name

But in these pictures the tags are to the right of the name

[jonpas]

Yep that's exactly due to Squad Leader position being from old system, title next to the name is as well, but Squad 2IC is from new system (as much as I know). I do believe having Squad Leader below name makes it look better though, can differentiate with everyone else easier.

[codethirteen]

Fixed in dev. This will be pushed in the next update. As an aside, if we assign classes to everything where possible, rather than hardcoding in linebreaks, etc., we can more easily fix this with pure CSS and then we don't have to worry about old/new systems.

[jonpas]

I suggest to revert this, 2 reasons:

• Conflicts with titles next to name, eg. Joel Restrepo has both Squad Leader and First Sergeant UX501 and it looks bad (look on dev page @codethirteen )
• Looks better on a separate line, makes it clearer to see who is the squad leader in my opinion

I think we should instead look into moving Squad 2IC below name as well, again we come to Squad Leader title using old system and Squad 2IC the new one though.

[jonpas]

@codethirteen bump (read above comment)

[codethirteen]

Sure we can revert this, it was just a <br> tag.

[jonpas]

If you agree, yes, I am not trying to be dictator here. :grin:

[codethirteen]

Thinking about it, it will be better to not put a <br> tag back in, but to give it a CSS class instead. If we do that with the old and the new tag systems we can style both much easier, and you can use CSS to target ::before to add the <br> if we want it. Much easier to maintain...

[jonpas]

Yep I agree!

Also, one line code is written in markdown like:

• backtick code backtick

Multiline:

• 3x backtick
• code
• 3x backtick

[codethirteen]

Yeah I wrote that on my phone. Funny thing now I edited it from desktop browser it still looks screwed up.

[jonpas]

Heh weird!

[codethirteen]

What differences are there in the old and new systems? I'm wondering how hard it would be to make them all part of the same system. This is yet more spaghetti we have to untangle!

[jonpas]

Not sure, I haven't looked into it any more.

[jonpas]

This has been done in 2015.05 update.