MattMills / stellarstellaris-win

StellarStellaris: Windows Edition - C++ to improve the Stellaris player experience
GNU General Public License v3.0
26 stars 2 forks source link

Hull/Shield/Armor Regen overflow patch no longer works in Stellaris v3.11.3 #13

Open matathias opened 4 months ago

matathias commented 4 months ago

Using the Stellar Stellaris version from the "Build stellarstellaris Windows #46" action, hull/shield/armor regen still overflows on Stellaris v3.11.3.

This version of Stellar Stellaris worked just fine on Stellaris v3.10.x, so likely something about the version update broke the patch.

Tangential, but the artifact from the most recent build action has expired, so new downloads of the build are no longer possible.

KeinNiemand commented 1 month ago

I've disabled everything except the regen overflow and reenabled the regen overflow that was commented out for some reason. The regen overflow seems to still for for Stellaris 3.12.x but I'm not sure if my testing is valid is I had trouble getting overflow at all (maybe you have to take damage or something).
Could you test if the regen overflow fix works in the new build from https://github.com/MattMills/stellarstellaris-win/actions/runs/9931603867?

matathias commented 1 month ago

I did some quick and dirty tests with the new build. Stellaris version 3.12.5, with only one mod to make it easier to test regen overflow.

Obscene levels of regen (100000%) still seem unstable, but a less-obscene (though still pretty ridiculous) regen value of 1000% seems to work, even with 200 million hull points. I didn't test combat, but I'm pretty sure in-combat regen is slower than out-of-combat regen. So I'd tentatively say that your fix works. Thanks!