search

MattRogowski / MyReactions

MyBB plugin - Add emoji reactions to posts
8 stars 6 forks source link

Handle DB tables on uninstall #28

Open Eldenroot opened 8 years ago

Eldenroot commented 8 years ago

Is there any protection mechanism to not lose DB table with given reactions on uninstall? If not, can be add any?

MattRogowski commented 8 years ago

Hm, uninstalling is really meant to remove everything - on some plugins I have a confirmation when you install, I could add that with an option to export the data first?

Eldenroot commented 8 years ago

In Thank you like/plugin there was a lock file - which must be deleted first to delete all your data from DB. It has been replaced by a confirmation dialog on uninstall.

Maybe you can use one of these approaches.

https://github.com/Cu8eR/MyBB_Thank-you-like-plugin/commit/51792a1210539a6cfc8b98fa05a0ca51cb386911

EDIT: It would be better than lose everything on missclick

MattRogowski commented 8 years ago

Yeah I'll put something in, have always thought the current system is pretty risky. A lock file is an interesting idea, but in MySupport I have a confirmation page so will probably do the same.