CSS margin bug - Githubissues

MattRogowski / MyReactions

MyBB plugin - Add emoji reactions to posts

8 stars 6 forks source link

CSS margin bug #38

Open Eldenroot opened 7 years ago

Eldenroot commented 7 years ago

Maybe related to #32 Everything seems to be fine except one thing - the margin is different for buttons for post with and without reactions.

Eldenroot commented 7 years ago

It is because of the border used for buttons (1px -> 2px) so the height of the button should be lowered by 1px to fix this issue and make the look unified

MattRogowski commented 7 years ago

Do you have a screenshot of what you're seeing? I thought I'd sorted all the issues with the different border widths

Eldenroot commented 7 years ago

Of course, here it is: padding

I fixed this issue by my PR, but it was messy.

MattRogowski commented 7 years ago

Grrr, I have half a mind to start all the CSS again now, need to change where margins are applied. Will have a look into it.