search

MattShannon / bandmat

A banded matrix library for python.
Other
26 stars 9 forks source link

'-Wno-unused-but-set-variable' causes error during install #7

Closed engiecat closed 6 years ago

engiecat commented 6 years ago

Hi.

I'm currently using Windows 10 with VS2017. While installing bandmat via pip, '-Wno-unused-but-set-variable' is not recognized by the compiler, causing error during the installation.

Commenting out the part in setup.py seems to alleviate the issue. (though with many warnings)

beausoft commented 6 years ago

I have this problem too.

engiecat commented 6 years ago

@beausoft https://github.com/MattShannon/bandmat/blob/aa58eaf8919760b786ccf91653a8902f229fdfc5/setup.py#L46-L60

comment out Line 49 and 57 did solve the problem and for now it works fine :)

r9y9 commented 6 years ago

This should be fixed by #6 but unfortunately, @MattShannon doesn't seem to be on GitHub these days...

IwraStudios commented 6 years ago

@r9y9 You might want to email him: matt.shannon@cantab.net

MattShannon commented 6 years ago

Sorry, I've been meaning to sort this out for ages. I'll have a closer look. I use a darcs repo behind the scenes so my preference is to fix the windows build issues there rather than merging the outstanding PR. Thanks so much for the feedback and patience!

MattShannon commented 6 years ago

Windows builds should be fixed now. Please let me know if you experience any further issues.