search

MattSurabian / aes-gcm-stream

A NodeJS Module that implements AES256 GCM encryption and decryption using streams
MIT License
11 stars 1 forks source link

Broken semver #9

Closed MattSurabian closed 9 years ago

MattSurabian commented 9 years ago

When I merged #4 I should have cut 2.0.0 NOT 1.1.0 because switching where the MAC is located is a breaking change for users of 1.0.0.

Fix is to cut 1.1.2 which will be identical to 1.0.0. Deprecate 1.1.1 and 1.1.0 on npm, then cut a new 2.0.0 release based on master.

Bleh.

calvinmetcalf commented 9 years ago

dude just unpublish 1.1.0 and republish as 2.0.0

MattSurabian commented 9 years ago

I thought unpublish wasn't actually allowed anymore

calvinmetcalf commented 9 years ago

nope, what isn't alowed is to republish with the same version number

On Mon, Apr 20, 2015 at 3:09 PM Matthew Surabian notifications@github.com wrote:

I thought unpublish wasn't actually allowed anymore

— Reply to this email directly or view it on GitHub https://github.com/MattSurabian/aes-gcm-stream/issues/9#issuecomment-94543973 .

MattSurabian commented 9 years ago

This mess is cleaned up. Thanks to @calvinmetcalf and @leobalter for reminding me unpublish was still allowed before I went too far down this rabbit hole.

I'm going to be more careful when cutting versions next time.

:fire: