search

MattTriano / analytics_data_where_house

An analytics engineering sandbox focusing on real estates prices in Cook County, IL
https://docs.analytics-data-where-house.dev/
GNU Affero General Public License v3.0
9 stars 0 forks source link

Parcel assessment dwh dev #90

Closed MattTriano closed 1 year ago

MattTriano commented 1 year ago

Closes #89

MattTriano commented 1 year ago

I'm kind of confused about this. The PR already merged successfully (and I had pulled the updated main back into my local). I followed the given steps (below), I pulled the branch, I found there weren't any changed files (although there was a new commit; the merge commit). As I'm not that concerned with having an immaculate history, I'll probably add another commit to merge it again.

git pull origin main
git checkout parcel_assessment_dwh_dev
git merge main
<resolve merge commits>
git push -u origin parcel_assessment_dwh_dev
MattTriano commented 1 year ago

Well that's something. After executing git push -u origin parcel_assessment_dwh_dev from my local repo, GitHub closed this out this PR (although it shows the PR was closed rather than merged, while it was definitely merged). Kind of irritating; I was ok with having an extra merge commit in the history, but that's easy for someone reading history to identify and understand. This situation, however, is bizarre and is a real speedbump when reading.