MatteCarra / AccA

Acc app allows to edit acc config file and add a tile to start and stop acc deamon
GNU General Public License v3.0
1.19k stars 85 forks source link

Separate `cooldown_temp` from `max_temp` and `max_temp_pause` in UI #225

Open tamas646 opened 1 year ago

tamas646 commented 1 year ago

Please separate the cooldown_temp setting from max_temp and max_temp_pause in the UI as these are fully independent settings and currently they're in a confusing arrangement. (see acc config entry descriptions below)

# cooldown_temp (ct) # Default: 35 # Temperature (°C) at which the cooldown cycle starts. # Cooldown reduces the battery degradation rate by lowering the device's temperature. # Requires cooldown_current or cooldown_charge and cooldown_pause, explained above.

# max_temp (mt) # Default: 45 # max_temp_pause (mtp) # Default: 90 \ # Those two work together and are NOT tied to the cooldown cycle. # Think of max_temp as the cooldown plan B (for when the cooldown cycle doesn't help). # On max_temp (°C), charging is paused for max_temp_pause (seconds).

I've been using this app for a while and I believed that all three temperature configurations (cooldown_temp, max_temp and max_temp_pause) are sticked together. I thought that configuring 35 degrees for cooldown_temp and 40 degrees for max_temp means that acc will keep the battery's temperature between these two values. But that's not true. cooldown_temp and max_temp are fully independent settings that should not be placed together in the UI. Rather it should be put next to the cooling cycle settings (cooldown_capacity, cooldown_charge and cooldown_pause) to make sure that it won't confuse anyone else.

I've attached some screenshot which shows where the cooldown temperature is misleading and how it could possibly be solved.

IMG_20221229_211831 IMG_20221229_211850 IMG_20221229_212121