Bug Fixing - Githubissues

Matteas-Eden / roll-for-reaction

An extension of react-rpg inspired by DnD 5e

https://matteas.nz/roll-for-reaction

MIT License

7 stars 3 forks source link

Bug Fixing #273

Closed Pyxxil closed 4 years ago

Pyxxil commented 4 years ago

GitHub Issue (If applicable): #272, #270 , #269

PR Type

What kind of change does this PR introduce?

Bugfix

What is the current behavior?

The code base has several bugs.

What is the new behavior?

It has fewer (but also probably more) bugs.

PR Checklist

Please check if your PR fulfills the following requirements:

[x] Tested code with current upstream repo
[ ] Added new tests to the test suite for the feature
[ ] Tested the full test suite, and ensured that the feature does not break current build.
[ ] Docs have been added/updated which fit (for bug fixes / features)
[ ] Contains NO breaking changes
[x] Associated with an issue (GitHub or internal)
[ ] Checked licensing of Frameworks/Libraries (if applicable)

Other information

You'll notice the 'Contains NO breaking changes is unticked. This PR does contain breaking changes surrounding the ability to cheat.

Internal Issue (If applicable): closes #272, closes #270, closes #269