search

MatteoBattilana / WeatherView

WeatherView is an Android Library let you make cool weather animations for your app
Apache License 2.0
514 stars 80 forks source link

[Library][Manifest] android:allowBackup="true" #16

Closed JonathanMercandalli closed 6 years ago

JonathanMercandalli commented 6 years ago

Do you really need that line in your lib manifest? (see your full manifest here)

android:allowBackup="true"

On client app, could be nice to use android:allowBackup="false" too. For now, here the compilation error if the client app do not use allowBackup.

> Manifest merger failed : Attribute application@allowBackup value=(false) from AndroidManifest.xml:16:9-36
    is also present at [com.github.MatteoBattilana:WeatherView:2.0.2] AndroidManifest.xml:12:9-35 value=(true).
    Suggestion: add 'tools:replace="android:allowBackup"' to <application> element at AndroidManifest.xml:15:5-35:19 to override.

Thks a lot for your lib =)

magneticflux- commented 6 years ago

No, I don't think that's needed. I'll investigate and release a new version very soon.

JonathanMercandalli commented 6 years ago

Nice (and thank you for your quick answer 👍)

magneticflux- commented 6 years ago

@JonathanMercandalli 2.0.3 should fix your issue! If not, just reopen this issue and we can investigate further.

JonathanMercandalli commented 6 years ago

@magneticflux- gg, thks a lot