search

MatteoGodzilla / Dj-Engine

A Dj Hero 2 Clone for PC :)
56 stars 5 forks source link

[BUG] Side-to-side crossfades break combo unless the player pass through the middle #13

Closed jummy0 closed 4 years ago

jummy0 commented 4 years ago

Describe the bug When playing a side-to-side crossfade (left -> right; right -> left), the combo will be dropped unless the player passes through the center on the way to the opposite side. For controller this isn't much of an issue, but for keyboard it's very noticeable.

To Reproduce Steps to reproduce the behavior:

  1. Play a song with a side-to-side crossfade.
  2. Go directly from holding Crossfade Left to holding Crossfade Right without letting go.
  3. Combo is broken.

Expected behavior Combo should continue even if the player doesn't pass through the center crossfade state.

Desktop (please complete the following information):

jummy0 commented 4 years ago

Still relevant in version 1.4.

MatteoGodzilla commented 4 years ago

fixed with commit a544806ffaac22fb4183fdbc285889b6f667c8c1