search

MatteoGodzilla / Dj-Engine

A Dj Hero 2 Clone for PC :)
56 stars 5 forks source link

[BUG] results screen does not report full combo if the combo is less than the note count #30

Closed jummy0 closed 4 years ago

jummy0 commented 4 years ago

Describe the bug If the combo of a song is a lower number than the note count (i.e., there are any simultaneous hits), the results screen will not report a full combo.

To Reproduce Steps to reproduce the behavior:

  1. Play a song with simultaneous hits (the DJH2 tutorials are easy choices)
  2. Get a full combo
  3. The results screen does not congratulate you.

Expected behavior The results screen should report a full combo even if the combo is less than the note count.

Screenshots image

MatteoGodzilla commented 4 years ago

changed the full combo logic on commit a544806ffaac22fb4183fdbc285889b6f667c8c1