MatteoLacki / IsoSpec

Libraries for fine isotopic structure calculator.
Other
35 stars 10 forks source link

CMakeLists.txt : new code to provide a SONAME to the so lib ? #29

Closed lopippo closed 5 years ago

lopippo commented 5 years ago

Greetings, Fellow Developers,

I would like to add some CMake code to ensure that the library is generated with a proper SONAME. I'll need this for the Debian packaging. Would you accept that code?

Sincerely, Filippo

lopippo commented 5 years ago

Also, I'll fix the output of the library build in the CMake file, because it misses the ++ in the lib name.

michalsta commented 5 years ago

Sure. Be warned though: the CMake was an external contribution, to make IsoSpec build on MSVC. As we don't have MSVC ourselves, we haven't been using or maintaining it, so it might be in any state of bitrot... Having said that, fixes of course welcome :)