Closed lopippo closed 4 years ago
michalsta
commented
4 years ago Right. Merging this now, thanks for the great work :)
I will wait for a week or two to see if any issues surface, and then apply this PR to the develop branch too. Right now it's like two "whitespace fixes" commits ahead, so it should work with no changes with that too.
lopippo
commented
4 years ago Very good, thank you veru much, this will make maintaining IsoSpec in various environments much easier! Ciao Filippo
lopippo
commented
4 years ago On Wed, Jun 10, 2020 at 06:37:52AM -0700, Michał Startek wrote:
Right. Merging this now, thanks for the great work :)
I will wait for a week or two to see if any issues surface, and then apply this PR to the develop branch too. Right now it's like two "whitespace fixes" commits ahead, so it should work with no changes with that too.
Ok, since the merge to version_2_1 was accepted and done, then I'll modify some of the debian/patches since they do not apply anymore : the build system is no more to be patched-in : it is there :-).
I'll finalise this and send a pull request.
Cheers, Filippo
--
⢀⣴⠾⠻⢶⣦⠀ Filippo Rusconi, PhD ⣾⠁⢠⠒⠀⣿⡁ Research scientist at CNRS ⢿⡄⠘⠷⠚⠋⠀ Debian Developer ⠈⠳⣄⠀⠀⠀⠀ http://msxpertsuite.org http://www.debian.org
book: http://www.lavoisier.fr/livre/notice.asp?id=3LKW2OAR2KROWZ
http://books.google.fr/books?id=2NmguxmEI1sC&printsec=frontcover&dq=rusconi+f+lavoisier&hl=fr&sa=X&ei=nGGOUt2SH_Ly0gX0uIHoBQ&ved=0CDUQ6AEwAA#v=onepage&q&f=falseGénétique Quantitative et Évolution & Plateforme PAPPSO UMR CNRS 8120 – INRA – Université Paris-Sud – AgroParisTech - Université Paris-Saclay http://moulon.inra.fr/ & http://pappso.inra.fr/ Ferme du Moulon 91190 Gif-sur-Yvette France Tel : +33 (0)1 69 33 23 54 Fax : +33 (0)1 69 33 23 40
Greetings, Fellow Developers,
this time the modifications have been implemented in the version_2_1 branch.
The debian packaging is highly tricky because the package needs to build 3 artifacts using 3 different build systems: CMake (C++), pybuild (Python3) and R... I hope that works as expected. My first tests seem to indicate so. Anyways, I'll fix anything.
The CMake-build system will be abundantly modified to cope with MinGW64 and APPLE environments as soon as I have a hand on them (currently they only serve as a placeholder).
In the hope that you find these modifications useful...
Cheers, Filippo