search

MatteoMeil / node-native-printer

Node module to print from nodejs apps
83 stars 41 forks source link

can you add edge-js? #7

Closed ayami123 closed 5 years ago

ayami123 commented 6 years ago

can you add another if in there? if electron true else if edge else edge-js ?

this is what i did.

before const edge = require(../../${process.env.ELECTRON == 'true' ? 'electron-' : ''}edge); after const edge = require(../../${process.env.ELECTRON == 'true' ? 'electron-' : ''}edge-js);

but if it will be implemented in here wouldn't it be better if there are 3 conditions for electron, edge and edge-js ?

ThomasKranitsas commented 5 years ago

@ayami123 I needed support for electron-edge-js so I forked this repo and added support for both edge-js and electron-edge-js.

You can find it here https://github.com/ThomasKranitsas/node-native-printer

@MatteoMeil let me know if you want me to create a PR.

MatteoMeil commented 5 years ago

I'm sorry for replying after so much time. I didn't know about edge-js. If you require it and you want to be included in the plugin, fork this repo, make changes and submit me a PR. @ThomasKranitsas if you submit a PR I can include your changes. Make sure those changes are stable.

After merging changes i will tag version 1.0.0

ThomasKranitsas commented 5 years ago

I'll create a PR once I manage to get it working properly.

Currently, I'm facing this #8

MatteoMeil commented 5 years ago

Sorry for this long period of absence due to a lot of work and study

https://github.com/MatteoMeil/node-native-printer/commit/c9f922a15dcf9940e0cae0dcee82166b7e89ca70 solve this issue and #13

I will upload updates on npm soon. Meanwhile you can install this using 

npm i https://github.com/MatteoMeil/node-native-printer.git