MatteoNasci / VOCASY

Voice chat system
MIT License
1 stars 1 forks source link

Two Exception, and can't change Settings #7

Open OverTook opened 6 years ago

OverTook commented 6 years ago

OverflowException: Number overflow. Concentus.Structs.OpusEncoder.Encode (System.Single[] in_pcm, Int32 pcm_offset, Int32 frame_size, System.Byte[] out_data, Int32 out_data_offset, Int32 max_data_bytes) ConcentusDataManipulator.FromAudioDataToPacket (System.Single[] audioData, Int32 audioDataOffset, Int32 audioDataCount, VOCASY.VoicePacketInfo& info, VOCASY.Utility.GamePacket output) (at Assets/VoiceChat/Scripts/ConcentusDataManipulator.cs:23) VOCASY.VoiceDataWorkflow.OnMicDataProcessed (IVoiceHandler handler) VOCASY.Common.VoiceHandler.Update ()

And Other Exception

IndexOutOfRangeException: Array index is out of range. Concentus.Structs.OpusEncoder.Encode (System.Single[] in_pcm, Int32 pcm_offset, Int32 frame_size, System.Byte[] out_data, Int32 out_data_offset, Int32 max_data_bytes) ConcentusDataManipulator.FromAudioDataToPacket (System.Single[] audioData, Int32 audioDataOffset, Int32 audioDataCount, VOCASY.VoicePacketInfo& info, VOCASY.Utility.GamePacket output) (at Assets/VoiceChat/Scripts/ConcentusDataManipulator.cs:23) VOCASY.VoiceDataWorkflow.OnMicDataProcessed (IVoiceHandler handler) VOCASY.Common.VoiceHandler.Update ()

, In addition, there is an error. i can't change Settings.asset in VoiceChat Folder. When I press the start button, it goes back to its original condition.

thx for your GOOD asset. I always feel thankful.

MatteoNasci commented 6 years ago

The voice chat settings scriptable object automatically reads from file in order to set its values. You have to call its method SaveCurrentSettings() , which will write on that file. About the exceptions I will eventually fix that, currently I am doing an overall fix and rework to make everything simpler and smoother so it may take some time

MatteoNasci commented 6 years ago

Next commit I will also allow to Save/Restore the settings from the scriptable object's inspector window

OverTook commented 6 years ago

@MatteoNasci Wow, this news makes me happy. I'm always indebted to you. Thank you.