MatteoZambra / Developmental-Approach-DBN

Support code
0 stars 0 forks source link

`dbns`: missing code? #3

Open dvdplm opened 3 years ago

dvdplm commented 3 years ago

The main_train.py references a dbns package that is not available on pypi. Where do I find this package?

MatteoZambra commented 3 years ago

That dbns is a module I wrote for the purpose of the work. In the beginning of the main_train.py you see the line sys.path.append(os.getcwd() + r'\dbp')? Means that I am pointing to the directory dbp where the module dbns (and the others imported thereafter) is saved. All these are written by me. So no need to search it on pypi. Hope it helps

dvdplm commented 3 years ago

sys.path.append(os.getcwd() + r'\dbp') uses \, i.e. Windows backslashes. That doesn't work on non-Windows and is not the way to handle paths portably.

Is this code windows-only?

MatteoZambra commented 3 years ago

Developed on Windows. Of course you can change \ to / and run it on non-Windows OS. I am sorry I did not think about portability when writing it

dvdplm commented 3 years ago

Developed on Windows. Of course you can change \ to / and run it on non-Windows OS. I am sorry I did not think about portability when writing it

Don't be sorry, bugs happen!

I can change the slash and run it but that's not the real fix... it would be good to use the proper python way of appending folders to a path.