Matter-Overdrive-Community-Edition / MatterOverdrive-Community-Edition-1.12.2

Sci-Fi minecraft mod
GNU General Public License v3.0
18 stars 16 forks source link

Cant break Stone Brick objects with omnitool #45

Closed TheNumenorean closed 2 years ago

TheNumenorean commented 2 years ago

Describe the bug Using the omni-tool on stone brick blocks, like the basic block, stairs, slabs, etc., does not break the block.

To Reproduce Steps to reproduce the behavior:

  1. Place stone brick variants in the world
  2. Hold right click with a charged omni tool while facing the block
  3. The beam intersects the block, generates sparks, but the block does not get damaged or break.

Expected behavior The block should break.

Screenshots image

please complete the following information:

infiniteblock commented 2 years ago

Do they have a harvest level? Had this issue with some mod blocks that don't set a harvest level and had to add one with craft tweaker

TheNumenorean commented 2 years ago

Poking around in the BlockStoneBrick class it doesnt look like it, so perhaps there need to be a default assumed? Presumably if a vanilla block can not have one it is not unreasonable for modded block to not have one either.

infiniteblock commented 2 years ago

Im not sure what we can do differently. as bypassing the check for if we can mine allows you to break the block but you don't have any drops.

We used this in our pack as a few mods don't set a harvest level. import crafttweaker.item.IItemStack; import crafttweaker.block.IBlock; import crafttweaker.block.IBlockDefinition;

val Orebenitoite = as IBlock; val Oreyellorite = as IBlock; val Oreanglesite = as IBlock; val Oreosmium = as IBlock;

var OrebenitoiteDef = Orebenitoite.definition; var OreyelloriteDef = Oreyellorite.definition; var OreanglesiteDef = Oreanglesite.definition; var OreosmiumDef = Oreosmium.definition;

OrebenitoiteDef.setHarvestLevel("pickaxe", 2); OreyelloriteDef.setHarvestLevel("pickaxe", 3); OreanglesiteDef.setHarvestLevel("pickaxe", 3); OreosmiumDef.setHarvestLevel("pickaxe", 3);