Part Fan Gcode being generated when printer config has no fan control

[johnoly99]

v1.7.0 SeeMeCNC version:

Printer/Features has fan unchecked, but gcode still has fan controls turning on mosfets for fans.

seemecnc_eris.zip

[larsbrubaker]

Validated: This is a bug but NOT a regression (this occurs in both 1.5.3 & 1.6.2). We will fix this with the next release, but not pull the current release - as it is in feature freeze and can only be pulled for regressions.

Open Question:

• Should we ensure start and end gcode contain no M106 or M107 if fan is turned off?
  • No, this will allow use of the M106 M107 command for potentially other things. Just ensure the auto generated code is not emitting these commands.

Work to correct:

• [ ] Write new failing test; validate created gcode contains no M106 when no fan exists
• [ ] Write new failing test; validate no M107 is emitted when no fan exists
• [ ] Write new test; M106 emitted when fan exists.
• [ ] Write new test; M107 is emitted when fan exists.
• [ ] Make the failing test pass

[johnoly99]

My guess is i think if there's any M106/107 in the start/end gcodes leave those there. there are instances in teh past, on non stock machines anyways, where i've used the fan Mcodes to trigger other "things" for "reasons" haha. In those cases, i would want to control the M codes with the start/end but not turn on by itself when i didn't explicitly tell it to in one of those cases.

Thanks man!

[larsbrubaker]

Sounds good. I've updated our plan to include this.

Thanks!