search

MatterHackers / MatterControl

3D printing software for Windows, Mac and Linux
http://www.mattercontrol.com/
BSD 2-Clause "Simplified" License
455 stars 183 forks source link

Firmware updater fails due to missing appdata/firmware folder #2229

Open jlewin opened 7 years ago

jlewin commented 7 years ago

Expected MatterControl should create folder if missing

Actual Directory is not created and downloaded firmware is not copied to disk at expected path

larsbrubaker commented 7 years ago

Investigation: The firmware folder is only created in the user data directory if backup is enabled. Change it to always ensure the folder exists.

// Backup Firmware
await Task.Run(() =>
{
    // Create the firmware directory if needed
    Directory.CreateDirectory(FirmwareDirectory);

    RunAvrDude(GetFlashCommand(backupFirmwareLocation, TransferType.r));
});
jlewin commented 7 years ago

@larsbrubaker - Is this a design_tools bug? I thought this was observed on 1.7 Experimental builds when flashing Pulse machines

larsbrubaker commented 7 years ago

This is happening in both. It is only when we disable the backup. At least that is my recollection.

On Jul 19, 2017 10:35 PM, "John Lewin" notifications@github.com wrote:

@larsbrubaker https://github.com/larsbrubaker - Is this a design_tools bug? I thought this was observed on 1.7 Experimental builds when flashing Pulse machines

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MatterHackers/MatterControl/issues/2229#issuecomment-316601585, or mute the thread https://github.com/notifications/unsubscribe-auth/ABGsvJVl2Zd9Rhzb7pzYzix90XhaugCiks5sPucDgaJpZM4OJ_4O .