Disable re-slice button on loaded g-code

MatterHackers / MatterControl

3D printing software for Windows, Mac and Linux

http://www.mattercontrol.com/

BSD 2-Clause "Simplified" License

460 stars 185 forks source link

Disable re-slice button on loaded g-code #5368

Closed jlewin closed 2 years ago

jlewin commented 2 years ago

Fix #5248

jlewin commented 2 years ago

Two highly related issues related to this seem to be:

Invalid "Save As" prompt when printing stand-alone gcode files:

Slice button enabled when loading stand-alone gcode files:

Same fix would be easy to apply and could be included in this PR if they make sense. Thoughts?

jlewin commented 2 years ago

The two related issues are too similar and too inconvenient to ignore. Adding into this PR for consolidated review and consideration

jlewin commented 2 years ago

One final thought... the UI could better convey what file is loaded. Most of the time with autogenerated MCX files, it really doesn't matter but it's extremely unclear at a glance to see that MC is in stand-alone GCODE mode, especially given no model exists to render on the bed after load.

GCODE only files could pop to the top layer on load and take the perf hit instead of showing an empty bed
Glyph or filename could be featured prominently when GCODE content is loaded

Anything that clarifies the switch between model and GCODE only modes would help. The disable animation on Model/3D/2D is good but not enough

Just some thoughts after going back and forth a ton

jlewin commented 2 years ago

One last related thought:

EditContext.FreezeGCode and EditContext.IsGCodeSource and BedConfig.EditableScene seem to encompass the same state and concepts however it's no longer clear the nuance between them. Please review their use on the PR to make sure the right property is used.

larsbrubaker commented 2 years ago

Thanks for all the work. I'll go through this on Tuesday (hopefully) and check that everything looks good. Looks great at a glance but I'll pull the code and run some tests.