MatterMiners / cobald

Cobald is an Opportunistic Balancing Deamon
https://cobald.readthedocs.io
MIT License
11 stars 12 forks source link

Read config after daemon initialisation #112

Closed maxfischer2781 closed 2 years ago

maxfischer2781 commented 2 years ago

This PR swaps the order of initialising the daemon runtime and reading the configuration.

Closes #106.

codecov[bot] commented 2 years ago

Codecov Report

Merging #112 (59ac3a8) into master (81a2ca9) will decrease coverage by 0.43%. The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
- Coverage   92.98%   92.55%   -0.44%     
==========================================
  Files          34       34              
  Lines        1140     1141       +1     
  Branches      166      167       +1     
==========================================
- Hits         1060     1056       -4     
- Misses         58       61       +3     
- Partials       22       24       +2     
Impacted Files Coverage Δ
src/cobald/daemon/runners/service.py 90.90% <ø> (-0.27%) :arrow_down:
src/cobald/daemon/runners/trio_runner.py 94.64% <33.33%> (-5.36%) :arrow_down:
src/cobald/daemon/runners/guard.py 100.00% <100.00%> (ø)
src/cobald/daemon/runners/meta_runner.py 92.50% <0.00%> (-2.50%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 81a2ca9...59ac3a8. Read the comment docs.

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging 4800c89784be4d00ff63b998da59eb56c624c4d2 into 81a2ca95fef72fae68b78f08b6070a7c328ca96a - view on LGTM.com

new alerts:

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging 54c2dbe2c3a091abf39bf9ea74c8865e62a49dff into 81a2ca95fef72fae68b78f08b6070a7c328ca96a - view on LGTM.com

new alerts:

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging 04b28a4dc8d078bab2e605fb2038469cd2a4eb13 into 81a2ca95fef72fae68b78f08b6070a7c328ca96a - view on LGTM.com

new alerts:

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging 1988f46bd7b0f86203efcad4adf624a946dd9f55 into 81a2ca95fef72fae68b78f08b6070a7c328ca96a - view on LGTM.com

new alerts: