search

MatterMiners / tardis

Transparent Adaptive Resource Dynamic Integration System
https://cobald-tardis.readthedocs.io
MIT License
14 stars 21 forks source link

Enable support for SSH command restrictions due to 2FA at NEMO #322

Closed giffels closed 10 months ago

giffels commented 10 months ago

The NEMO HPC is going to enable 2FA on the login nodes and SSH can be restricted to certain commands only. This requires to avoid && and $(whoami) in commands.

This pull request changes the behaviour of the Moab site adapter to be compatible with that change.

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (242e4c0) 98.87% compared to head (12c3b1b) 98.87%.

:exclamation: Current head 12c3b1b differs from pull request most recent head edcbea5. Consider uploading reports for the commit edcbea5 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #322 +/- ## ======================================= Coverage 98.87% 98.87% ======================================= Files 55 55 Lines 2218 2222 +4 ======================================= + Hits 2193 2197 +4 Misses 25 25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

giffels commented 10 months ago

What about the failing tests?

They are fixed in #315 and not related to the code changes. Please, ignore it.