MatterMiners / tardis

Transparent Adaptive Resource Dynamic Integration System
https://cobald-tardis.readthedocs.io
MIT License
15 stars 20 forks source link

Fix handling of squeue call with invalid jobid #326

Closed giffels closed 6 months ago

giffels commented 6 months ago

In case a job is already completed and only one non-existing job id is provided the squeue command is failing with exit code 1 and it prints "Invalid job id specified" to stderr. If two or more non-existing job ids or a mixture of existing ones and non-existings jobs are provided, squeue command succeeds.

This pull request is adjusting the handling of failed squeue commands correspondigly.

Thanks to @rodwalker for reporting it.

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (10072ef) 98.87% compared to head (d105f23) 98.87%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #326 +/- ## ======================================= Coverage 98.87% 98.87% ======================================= Files 55 55 Lines 2222 2225 +3 ======================================= + Hits 2197 2200 +3 Misses 25 25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.