search

MatterMiners / tardis

Transparent Adaptive Resource Dynamic Integration System
https://cobald-tardis.readthedocs.io
MIT License
14 stars 21 forks source link

Catch littered status feedback in csv_parser #338

Closed swozniewski closed 7 months ago

swozniewski commented 7 months ago

I observed a case where the ssh-executor running the squeue command returned slurm_status.stdout containing

Switch to work directory on corresponding scratch directory. Switch to work directory on corresponding scratch directory. Switch to work directory on corresponding scratch directory. 5545112||PENDING

where only the last line is expected to be returned from squeue. The other lines might be some system messages (?). This PR adds a filter that only keeps lines with "|" before feeding them into the csv-Parser.

swozniewski commented 7 months ago

I believe I addressed all comments. Please check again.

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.92%. Comparing base (5251da3) to head (2c3d2aa). Report is 11 commits behind head on master.

:exclamation: Current head 2c3d2aa differs from pull request most recent head bf59168. Consider uploading reports for the commit bf59168 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #338 +/- ## ========================================== + Coverage 98.87% 98.92% +0.04% ========================================== Files 55 55 Lines 2225 2226 +1 ========================================== + Hits 2200 2202 +2 + Misses 25 24 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.