MatterMiners / tardis

Transparent Adaptive Resource Dynamic Integration System
https://cobald-tardis.readthedocs.io
MIT License
14 stars 21 forks source link

Update site.rst for HTCondor Batch system adapter #345

Open SaidevPolisetty opened 5 months ago

SaidevPolisetty commented 5 months ago

Description about the "TardisDroneUuid" requirement incase of a change in the hostname (arbitrary and non-default)

giffels commented 4 months ago

Thanks for your contribution to the documentation of TARDIS. However, I think your note should go to the docs/source/adapters/batchsystem.rst instead and in this file in the HTCondor section. In addition, I would prefer to rephrase it, so that it is clear what attribute needs to be added where and what it will change.

Thanks, Manuel

@SaidevPolisetty is there any progress on that or do you need some help or have questions?

SaidevPolisetty commented 4 months ago

Thanks for your contribution to the documentation of TARDIS. However, I think your note should go to the docs/source/adapters/batchsystem.rst instead and in this file in the HTCondor section. In addition, I would prefer to rephrase it, so that it is clear what attribute needs to be added where and what it will change. Thanks, Manuel

@SaidevPolisetty is there any progress on that or do you need some help or have questions?

Yes, sorry, got side tracked with other works. I will update it today

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.92%. Comparing base (5251da3) to head (a4ac000). Report is 26 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #345 +/- ## ========================================== + Coverage 98.87% 98.92% +0.04% ========================================== Files 55 55 Lines 2225 2226 +1 ========================================== + Hits 2200 2202 +2 + Misses 25 24 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SaidevPolisetty commented 4 months ago

@giffels I have made the necessary changes.