search

MatthewBJane / ThemePark

Fun ggplot themes for popular culture
http://matthewbjane.com/ThemePark/
MIT License
196 stars 13 forks source link

Friends theme #13

Closed Alexis-vs closed 1 year ago

Alexis-vs commented 1 year ago

I like your repo ! So it was with pleasure that I offer you the friends theme from the series. You can see an example from examples.R script, Enjoy

lcpilling commented 1 year ago

Hi, thanks for the contribution! Two things:

First, we have had several discussions over the last days how to make the syntax more consistent between the themes, and also more versatile for users. Christopher Kenny has provided a theme (Finding Nemo) which includes more fill scales for discreet, etc., and so we've updated the template to utilize this. It also prompts contributors to document the functions for when they are packaged up properly. Would you consider updating your themes to use the new template? Hopefully not much work :) https://github.com/MatthewBJane/theme_park/blob/main/theme_template.R

Second, I like that the different text alements have different colours to follow the TV theme. But the actual blue for the points seems to clash with the red for the shading to me. Could you revisit? image

Thanks! Luke

Alexis-vs commented 1 year ago

Hi Luke !

Thanks for the feedback ! I updated the theme_friends.R according to the theme_template. For the colors, I applied several changes : title, and axis title (and points if geom_point) are in black to avoid confusion with the colors of a probable legend (but there are always all the colors in x & y axis :) )

friends_theme_example

Alexis

MatthewBJane commented 1 year ago

Okay so there is a conflict in the README.md and examples.R files are conflicting in this pull request. I think we can merge the new theme_friends commit, but lets just add Alexis to the readme and the examples manually.