Add a theme for the cinematic masterpiece, Finding Nemo

christopherkenny commented 1 year ago

This PR adds a theme inspired by Finding Nemo. Some things to note about the structure of this:

includes roxygen comments for functions, in case this turns into a package (let me know if you want some help structuring that! It's easier to change before there are too many themes.)
color and fill functions have _b (binned), _c (continuous), and _d (discrete) friends, following how viridis breaks these outs within ggplot2
for _b functions, scales is required. scales is already required by ggplot2 and is well maintained, so it shouldn't be a problem and it doesn't add any new weight to the function
includes Brit/Aussie/NZ-friendly misspellings that ggplot2 uses. The colour misspelling is included as an alternative, according to ggplot2 conventions.

lcpilling commented 1 year ago

Nice additions to the template! Good to think about making this better/easier in the long run, and getting people to add their documentation!

Matthew is running a poll on Twitter to see if people would prefer lots of individual themes or one mega "theme_park" theme with options. Would be interesting to know your thoughts.

https://twitter.com/MatthewBJane/status/1684691404147064833

MatthewBJane commented 1 year ago

If Christopher wants, I wouldn't mind also adding him as a collaborator so he can edit the package as he sees fit. He has some packages currently on CRAN, so his experience with that process would be helpful

lcpilling commented 1 year ago

The addition of the discreet scale fills etc really elevates this - love it

MatthewBJane / ThemePark

Add a theme for the cinematic masterpiece, Finding Nemo #14