MatthewBJane / ThemePark

Fun ggplot themes for popular culture
http://matthewbjane.com/ThemePark/
MIT License
196 stars 13 forks source link

Restructure as a valid R package #17

Closed christopherkenny closed 1 year ago

christopherkenny commented 1 year ago

This PR restructures theme_park into an R package. It does a lot, so happy to chat over details before any merging. Primary changes are listed below.

These files are generated by default as part of initializing an R package with devtools::create()

The next big bucket of changes is moving the .R files into the R/ folder so that the package knows what to use.

On the topic of README.Rmd, many packages use that now as it will let you put examples in the readme without doing anything crazy.

With the basic structure, we can then start adding package content.

Then beyond moving out of the R folder, we need to make a series of changes to the existing R folder

Finally, in utils.R, I've added new_theme_park_theme() which makes use of the template to create a new theme. This can be edited to add in any new constraints or checks.

Some near-term action items

Some later action items

MatthewBJane commented 1 year ago

Wow great job, Christopher! I am ready to merge when you are! I'll answer the near term items below:

christopherkenny commented 1 year ago
christopherkenny commented 1 year ago

Colors point is resolved. Good to merge by me.