legend.key fill

[ASKurz]

I think you're gonna want to adjust the fill setting for the legend.key for theme_barbie(). Here's an example of what currently happens:

library(tidyverse)
library(ThemePark)

mtcars %>% 
  ggplot(aes(mpg, wt)) +
  geom_point(aes(shape = factor(cyl))) +
  theme_barbie()

See the default gray background in the legend key? Here are two possible fixes:

mtcars %>% 
  ggplot(aes(mpg, wt)) +
  geom_point(aes(shape = factor(cyl))) +
  theme_barbie(barbie_font = FALSE)  +
  theme(legend.key = element_rect(fill = "white"))

mtcars %>% 
  ggplot(aes(mpg, wt)) +
  geom_point(aes(shape = factor(cyl))) +
  theme_barbie(barbie_font = FALSE)  +
  theme(legend.key = element_rect(fill = barbie_theme_colors["panel"]))

[ASKurz]

Here's a more radical option:

mtcars %>% 
  ggplot(aes(mpg, wt)) +
  geom_point(aes(shape = factor(cyl))) +
  theme_barbie()  +
  theme(legend.background = element_rect(fill = "white"),
        legend.key = element_rect(fill = barbie_theme_colors["panel"]))

[MatthewBJane]

I actually very much like the "radical" one. I will add this. This one is a bit tedious so I will probably do this tomorrow. I will follow up on this issue once it is done. Thanks for finding these flaws, Solomon!

[ASKurz]

Glad to be of service.

[ASKurz]

Update: To get it right, I think it might have to be this:

mtcars %>% 
  ggplot(aes(mpg, wt)) +
  geom_point(aes(shape = factor(cyl))) +
  theme_barbie()  +
  theme(legend.background = element_rect(fill = "white"),
        # note we're adjusting both fill and color settings
        legend.key = element_rect(fill = barbie_theme_colors["panel"],
                                  color =  barbie_theme_colors["panel"]))

[MatthewBJane]

totally forgot to come back to this... @christopherkenny or @lukepilling, is this worth implementing?

[lcpilling]

Seems like yes for Barbie. Would we need to check the other themes to make sure it didn't look "bad"? Or just implement the solution throughout?

[MatthewBJane]

Idk that seems like a huge pain. Probably implementing it in Barbie would be fine for now. Unless you or Chris want to try to implement it across the board. I don't think it is necessary for now though

[christopherkenny]

FYI, we could clean this up if we have specific choices, but ggplot2 version 3.5.0 has this as a breaking change (which fixes the ugly greys)/

We can see how that looks below: themes_test.pdf

Code to generate

``` devtools::load_all() library(ggplot2) library(patchwork) list_fn <- function(prefix) { fns <- utils::lsf.str("package:ThemePark") fns[startsWith(fns, prefix)] } p <- lapply(list_fn('theme_'), function(fn) { theme <- getFromNamespace(fn, 'ThemePark') mtcars |> ggplot(aes(mpg, wt)) + geom_point(aes(shape = factor(cyl))) + theme() + labs(title = fn) }) |> wrap_plots() ggsave(plot = p, filename = 'themes_test.pdf', width = 48, height = 36) ```

[christopherkenny]

And here's a png version, since it doesn't show as pdf.