MatthewBooth / OTAUpdates

Over-The-Air Updates for Android ROMs from ICS to Lollipop
http://ultimarom.com/
73 stars 109 forks source link

Include Android.mk also for non AOSP ROMs #64

Closed nilac8991 closed 9 years ago

MatthewBooth commented 9 years ago

Why would non-AOSP ROMs need the Makefile? Eclipse or Android Studio would be doing the building for those kinds of ROMs.

If you're thinking of CyanogenMod, AOKP, Paranoid Android and the like, they should use the aosp branch. They are all based off AOSP, and use these AOSP build system, which was the idea behind the branch name :)

MatthewBooth commented 9 years ago

Also, this should be set to merge into master, not stable :)

nilac8991 commented 9 years ago

But the AOSP one is behind some commits than the stable one as i still facing problems with the addons page

nilac8991 commented 9 years ago

No problem just helping :)

MatthewBooth commented 9 years ago

I merged master into aosp a couple of days ago to fix those issues.

nilac8991 commented 9 years ago

Yep i see now Thanks. I will just close the pull request ;)

MatthewBooth commented 9 years ago

Thank you for using the time to use this system, though :)

If there is still a problem, please don't hesitate to make an issue or pull request!

Matt

nilac8991 commented 9 years ago

Yeah i use it for my custom Resurrection Releases and i really appreciate your work done, the app is made in a very good manner :+1: