search

MatthewCroughan / NixThePlanet

Run macOS, Windows and more via a single Nix command, or simple nixosModules
MIT License
553 stars 14 forks source link

add `username` and `password` options #23

Closed ratson closed 7 months ago

ratson commented 7 months ago

Add options to config username and password.

MatthewCroughan commented 7 months ago

In creating this, I noticed that this is a bad idea. The reason it is a bad idea is because adding more characters at this stage via QEMU key inputs is likely to increase failure rates, and if you feed invalid characters we won't be able to catch the error, and the build will just hang forever. Whereas if we allow it to be configured in a second stage we get proper errors that can be handled.

This can be changed later in a second derivation, with guaranteed success via SSH, the same is true of disk size configuration. I have explained this before.