search

MatthewCroughan / octobalena

Control your 3d-printer with octoprint + octoscreen via balena!
GNU General Public License v2.0
49 stars 22 forks source link

Fix for various small issues #41

Closed thzinc closed 3 years ago

thzinc commented 3 years ago

Scope: octoprint, mdns-publisher Change-type: minor Signed-off-by: Daniel James daniel@thzinc.com

Fix for mdns-publisher

An unused CONTAINER_HOSTNAME was being used to determine whether to use the documented OCTOPRINT_HOSTNAME environment variable. This was preventing using a custom hostname as documented.

Fix for Octoprint's usage of the basedir

Fixed issues caused when Octoprint attempts to restore a backup by renaming this path

Because the Docker volume is mounted to /data, it cannot be moved/renamed. Changing this basedir to a folder within /data allows Octoprint to move/rename its directory within the mounted volume.

Fix for different spelling of OCTOPRINT_APIKEY environment variable

The update-balena-app.sh script was using OCTOPRINT_API_KEY instead of OCTOPRINT_APIKEY.

Fix for build dependencies

While trying to build the octoprint container, there were a few missing packages. I added what was missing, removed what was not findable, and combined multiple calls to install_packages.

thzinc commented 3 years ago

Also, many thanks to @MatthewCroughan for making this project available. This is super useful.