search

MatthewDorner / abcjs-vexflow-renderer

VexFlow renderer for ABC notation music using abcjs as parser.
GNU General Public License v3.0
23 stars 3 forks source link

Fixed html multiple tag #8

Closed ntolazzi closed 3 years ago

ntolazzi commented 3 years ago

There was an error with the multiple tag in the html file. This prevented the code from building via:

npm run-script build

which previously resulted in:

ERROR in Error: html-webpack-plugin could not minify the generated output. In production mode the html minifcation is enabled by default. If you are not generating a valid html output please disable it manually. You can do so by adding the following setting to your HtmlWebpackPlugin config: minify: false

See https://github.com/jantimon/html-webpack-plugin#options for details. For parser dedicated bugs please create an issue here: https://danielruf.github.io/html-minifier-terser/ Parse Error: <select id="tunebookSelect" multiple=11" style="width:300px;height:95px">........

This is now fixed with this pull request and it builds.

MatthewDorner commented 3 years ago

Thanks! Didn't get this error on my system for whatever reason.