Closed kamiyo closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 93.79%. Comparing base (
5494e54
) to head (89503a7
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Id to like to see if we need to do this for observations before publishing a release to avoid multiple breaking change releases.
Both detailed forecast and observations already return all values under properties
. So this PR also harmonized this package. We are good to release a new version if you have no other planned changes.
Added code to populate metadata in
update_forecast()
andupdate_forecast_hourly()
, and added properties to get the metadata. The metadata is only populated if response is not empty, in case the API returns metadata with empty periods.Added tests for the metadata.
Metadata keys are stored in a list, and populated by iterating through the keys; I felt this was the easiest and lowest code way to do it.