search

MatthewGrim / CFD_Codes

4 stars 4 forks source link

Add C++ Riemann code to this repository #24

Closed MatthewGrim closed 5 years ago

MatthewGrim commented 5 years ago

I have implemented previously a C++ version of the Riemann solver code I already have in python in this repository. This issue documents the addition of the serial C code to this repository. In this issue, the old, rusty code needs to be made to compile and output results from VTK as it used to.

MatthewGrim commented 5 years ago

The code currently compiles using CMake and runs with no output.

I need to link to the VTK libraries to produce output and find a way to make the addition of source files from the src directory a little cleaner.

MatthewGrim commented 5 years ago

The code works and compiles. The VTK output has an error which I need to tackle in a separate issue. The last thing to try to do here is to get the code to compile with a GLOB command.

MatthewGrim commented 5 years ago

Reading forums, I apparently should not use GLOB_RECURSE because of potential confusion in not knowing when to rebuild with CMake etc. Following conventional wisdom, I'm closing this issue.