search

MatthewGrim / Lunar_SPS

0 stars 0 forks source link

Test generic script functions, to ensure that the data being generated is correct #28

Closed MatthewGrim closed 6 years ago

MatthewGrim commented 6 years ago

This issue covers the validation of the generic scripts implemented in #25, by comparing results with hand generated simulations.

MatthewGrim commented 6 years ago

Testing the output, they are in the wrong format ... lighting is in epoc seconds when it should be in YYYY::MM:DD::hh::ss and the range reports are not generating the right information either

MatthewGrim commented 6 years ago

The problem is not insurmountable ... the conversion from epoch seconds to seconds is just an offset. But I need to know the simulation start time in epoch seconds to make this work.

For the range, the data is the issue - 30% of the way through, we're generated 8GB. We're looking at a huge amount of data, and it'll be due to the range reports. I may need to restart because of this.

MatthewGrim commented 6 years ago

On the plus side, simulations match, so numerically we are doing what we think we are doing. I now need to solve the unit problem.

MatthewGrim commented 6 years ago

Solving Epoch time problem

This is easy enough - the start epoch time is set explicitly in the simulations to be 31st of July at 10am. Applying this offset to epoch times will give the access time in seconds.

Solving the Range problem

To do this, I will need to restart the simulations and re-implement the range function to handle the case when the ranges are also plotted in time.

MatthewGrim commented 6 years ago

I've implemented these fixes and the reports are being generated with much less data. This should hopefully speed thing up too.

MatthewGrim commented 6 years ago

Because the melds I ran comparing like for like hand made and programmatic sims matched up, I am going to close this issue.

MatthewGrim commented 6 years ago

I do not need to change the script for reading in the ranges as it should as based on Darian's implementation, it should be able to handle both cases.