search

MatthewJohn / terrareg

Open source Terraform module registry with UI, optional Git integration and deep analysis
https://gitlab.dockstudios.co.uk/pub/terrareg
GNU General Public License v3.0
268 stars 20 forks source link

Deleting module version does not remove files #10

Closed pseudomorph closed 1 year ago

pseudomorph commented 1 year ago

when calling delete_module_version or delete_module_provider, which calls the former, archives and files associated with the module version are not removed from the system.

MatthewJohn commented 1 year ago

Thank you for raising this :) I'll create an upstream ticket - is there an urgency from your perspective on fixing this - or happy for it to be looked at within the next week?

Thanks Matt

MatthewJohn commented 1 year ago

Hey @pseudomorph ,

I raised an upstream ticket for this: https://gitlab.dockstudios.co.uk/pub/terrareg/-/issues/406

I've hopefully got an implementation for this sorted (pending test results!): https://gitlab.dockstudios.co.uk/pub/terrareg/-/merge_requests/340

Hopefully this looks okay - let me know if there's any issues :)

Many thanks Matt

MatthewJohn commented 1 year ago

Hey @pseudomorph ,

I've now merged this and released in 2.71.3. Hopefully this works as you'd hope - if not, feel free to re-open the issue :)

Thanks Matt