search

MatthewJohn / terrareg

Open source Terraform module registry with UI, optional Git integration and deep analysis
https://gitlab.dockstudios.co.uk/pub/terrareg
GNU General Public License v3.0
268 stars 20 forks source link

Log error details on failed tag import #17

Closed bmaximuml closed 1 year ago

bmaximuml commented 1 year ago

I was seeing this error (Tag failed to import) and struggling to understand its cause. Printing the contents of the error helps to identify what's actually going on. In my case, incorrect github perms.

Aware that you have a particular PR name format which I'm probably not meeting but I'm not sure what it is (could be useful to have this in your CONTRIBUTING.md?)

Have also signed up for an account on gitlab to prevent you from having to duplicate, waiting for approval.

MatthewJohn commented 1 year ago

Thanks you :) I'll get that shuffled along :)

Aware that you have a particular PR name format which I'm probably not meeting but I'm not sure what it is (could be useful to have this in your CONTRIBUTING.md?)

Ah, it's actually just commit messages (PR titles don't matter much) - I had documented on the README (https://github.com/matthewJohn/terrareg#committing), but you're right, it would be much more obvious and suited in the CONTRIBUTING.md

Have also signed up for an account on gitlab to prevent you from having to duplicate, waiting for approval.

Thanks - I'll approve in a sec :)

MatthewJohn commented 1 year ago

I'm happy to replicate etc. myself, but if you're happy/would like to, then that's great :) If/once you do, I assume these PRs can be closed in favour of gitlab ones? :)

bmaximuml commented 1 year ago

I'll rebase the commit messages in the PRs I've made today and push them up to gitlab. Happy then for these to be closed