search

MatthewKing / DeviceId

A simple library providing functionality to generate a 'device ID' that can be used to uniquely identify a computer.
MIT License
729 stars 118 forks source link

Reduced WmiDeviceIdComponent query time #14

Closed Zaczero closed 4 years ago

Zaczero commented 4 years ago

Previously the WmiDeviceIdComponent queried all properties from the class which takes quite a long time. Now it only queries one property specified by _wmiProperty which makes the whole process near-instant :- ).

Additionally, updated .gitignore with the latest Visual Studio version so it's compatible with various VS extensions.

MatthewKing commented 4 years ago

This looks great, thanks. Give me a couple of days to review properly and merge. Cheers!

MatthewKing commented 4 years ago

Would you mind removing the .gitignore changes? Should be good to merge after that. Thanks!

Zaczero commented 4 years ago

Would you mind removing the .gitignore changes? Should be good to merge after that. Thanks!

welp sure

MatthewKing commented 4 years ago

Thanks mate, much appreciated! Will get this merged and released as soon as I get a sec. Cheers

Zaczero commented 4 years ago

What's the reason behind such a basic .gitignore if I may ask?

MatthewKing commented 4 years ago

I'm just a weirdo I guess 😄