search

MatthewKing / DeviceId

A simple library providing functionality to generate a 'device ID' that can be used to uniquely identify a computer.
MIT License
729 stars 118 forks source link

Add OSX support #16

Closed techtim closed 4 years ago

techtim commented 4 years ago

Added 2 OSX parameters using new BashExecutorComponent:

MatthewKing commented 4 years ago

This looks great, thanks. I'll review, merge, and release it as soon as I get a chance.

MatthewKing commented 4 years ago

I've merged the changes. I'm pretty busy with work at the moment but I want to add a few more OSX components before I get this release out. Shouldn't be too long. Thanks again!

MatthewKing commented 4 years ago

Hey @techtim

Thanks again for this PR. I have one question for you as a Mac user. It looks to me like the serial number from "IOPlatformSerialNumber" would be a better fit for the "SystemUUID" component rather than the "ProcessorId" component. Would you agree, or am I off base here?

Cheers